[webkit-reviews] review granted: [Bug 188821] Transition ResizeReversePaginatedWebView API test from WKPageLoaderClient to WKPageNavigationClient : [Attachment 347708] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 21 15:17:57 PDT 2018


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 188821: Transition ResizeReversePaginatedWebView API test from
WKPageLoaderClient to WKPageNavigationClient
https://bugs.webkit.org/show_bug.cgi?id=188821

Attachment 347708: Patch

https://bugs.webkit.org/attachment.cgi?id=347708&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 347708
  --> https://bugs.webkit.org/attachment.cgi?id=347708
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347708&action=review

> Source/WebKit/UIProcess/API/C/WKPageRenderingProgressEvents.h:41
> +   
WKPageRenderingProgressEventFirstLayoutAfterSuppressedIncrementalRendering = 1
<< 4,
> +   
WKPageRenderingProgressEventFirstPaintAfterSuppressedIncrementalRendering = 1
<< 5,

These names are confusing (probably part of why we didn't want to expose them)
because they fire after rendering has been unsuppressed.


More information about the webkit-reviews mailing list