[webkit-reviews] review granted: [Bug 188800] [iOS][WK2] Misspelled words are not underlined : [Attachment 347697] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 188800: [iOS][WK2] Misspelled words are not underlined
https://bugs.webkit.org/show_bug.cgi?id=188800

Attachment 347697: Patch

https://bugs.webkit.org/attachment.cgi?id=347697&action=review




--- Comment #12 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 347697
  --> https://bugs.webkit.org/attachment.cgi?id=347697
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347697&action=review

> Source/WebKit/UIProcess/ios/TextCheckerIOS.mm:64
>      notImplemented();

Can we remove this notImplemented() here?

> Source/WebKit/UIProcess/ios/TextCheckerIOS.mm:164
> +    static int64_t nextSpellDocumentTag;

Not about this patch, but we should consider something like:

using SpellDocumentTag = int64_t;

...at some point, instead of using int64_t directly to represent a document
tag.