[webkit-reviews] review granted: [Bug 188810] Translate WebKit.LimitTitleSize API test into ObjC : [Attachment 347685] patch with updated title

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 188810: Translate WebKit.LimitTitleSize API test into ObjC
https://bugs.webkit.org/show_bug.cgi?id=188810

Attachment 347685: patch with updated title

https://bugs.webkit.org/attachment.cgi?id=347685&action=review




--- Comment #3 from Andy Estes <aestes at apple.com> ---
Comment on attachment 347685
  --> https://bugs.webkit.org/attachment.cgi?id=347685
patch with updated title

View in context: https://bugs.webkit.org/attachment.cgi?id=347685&action=review

> Tools/TestWebKitAPI/Tests/mac/LimitTitleSize.mm:76
> +- (void)observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object
change:(NSDictionary *)change context:(void *)context

void*

> Tools/TestWebKitAPI/Tests/mac/LimitTitleSize.mm:81
> +    waitUntilLongTitleReceived = true;

Seems like this is named opposite of what it means, but ok :)