[webkit-reviews] review granted: [Bug 188750] [WebGL] Contexts are not updated when display configuration changed. : [Attachment 347567] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 188750: [WebGL] Contexts are not updated when display configuration
changed.
https://bugs.webkit.org/show_bug.cgi?id=188750

Attachment 347567: Patch

https://bugs.webkit.org/attachment.cgi?id=347567&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 347567
  --> https://bugs.webkit.org/attachment.cgi?id=347567
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347567&action=review

Looks like a good change. r=me (but please confirm EWS is happy).

> Source/WebCore/platform/graphics/GraphicsContext3DManager.h:28
> +#include <WebCore/Timer.h>

Do we need to prefix this with WebCore when building in WebCore? Or is this
header accessed outside WebCore?

> Source/WebCore/platform/graphics/GraphicsContext3DManager.h:71
> +

Please remove this whitespace-only change.