[webkit-reviews] review granted: [Bug 188757] Make ResourceLoadObserver::logWebSocketLoading() handle websockets in detached frames : [Attachment 347550] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 188757: Make ResourceLoadObserver::logWebSocketLoading() handle websockets
in detached frames
https://bugs.webkit.org/show_bug.cgi?id=188757

Attachment 347550: Patch

https://bugs.webkit.org/attachment.cgi?id=347550&action=review




--- Comment #8 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 347550
  --> https://bugs.webkit.org/attachment.cgi?id=347550
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347550&action=review

> Source/WebCore/loader/ResourceLoadObserver.cpp:173
>	   return;

indent more

> Source/WebCore/loader/ResourceLoadObserver.cpp:184
> +    if (!shouldLog(document.page()->usesEphemeralSession()))

Either move assertion up or check page for null.