[webkit-reviews] review granted: [Bug 188735] [Cocoa] Update uses of wrapper template functions in WebKit for clarity, simplicity, better ARC readiness : [Attachment 347473] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Darin Adler <darin at apple.com>'s request for review:
Bug 188735: [Cocoa] Update uses of wrapper template functions in WebKit for
clarity, simplicity, better ARC readiness
https://bugs.webkit.org/show_bug.cgi?id=188735

Attachment 347473: Patch

https://bugs.webkit.org/attachment.cgi?id=347473&action=review




--- Comment #3 from mitz at webkit.org ---
Comment on attachment 347473
  --> https://bugs.webkit.org/attachment.cgi?id=347473
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347473&action=review

> Source/WebKit/ChangeLog:64
> +	   (-[WKProcessPool _configuration]): Fixed a storage leak by removing
leakRef,
> +	   which was not balanaced. This is not a copy or create function, so
it should not
> +	   return an object that requires a release to balance it.

Yes! I noticed this bug a couple of weeks ago and hadn’t gotten around to
writing it up.