[webkit-reviews] review granted: [Bug 168649] Relax Request constructor around referrers : [Attachment 347456] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 19 17:06:31 PDT 2018


Darin Adler <darin at apple.com> has granted Rob Buis <rbuis at igalia.com>'s request
for review:
Bug 168649: Relax Request constructor around referrers
https://bugs.webkit.org/show_bug.cgi?id=168649

Attachment 347456: Patch

https://bugs.webkit.org/attachment.cgi?id=347456&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 347456
  --> https://bugs.webkit.org/attachment.cgi?id=347456
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347456&action=review

> Source/WebCore/Modules/fetch/FetchRequest.cpp:62
> -	   return Exception { TypeError, "Referrer is not same-origin."_s };
> +	   return String { "client" };

This, and the code above, should be using String { "client"_s } so we get the
ASCIILiteral optimization. Same for "no-referrer"_s.


More information about the webkit-reviews mailing list