[webkit-reviews] review granted: [Bug 171656] Throw an exception if window.open() gets passed a URL that cannot be parsed : [Attachment 347463] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Rob Buis <rbuis at igalia.com>'s request
for review:
Bug 171656: Throw an exception if window.open() gets passed a URL that cannot
be parsed
https://bugs.webkit.org/show_bug.cgi?id=171656

Attachment 347463: Patch

https://bugs.webkit.org/attachment.cgi?id=347463&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 347463
  --> https://bugs.webkit.org/attachment.cgi?id=347463
Patch

Looks fine. Idiom for returning nullptr in such cases is pretty ugly.

For website programmers who did this by accident, it seems the exception is not
as clear as the wording of the console message was.