[webkit-reviews] review granted: [Bug 188566] Clean up CSSSelectorList after r234825 : [Attachment 347188] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 17 16:51:25 PDT 2018
Megan Gardner <megan_gardner at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 188566: Clean up CSSSelectorList after r234825
https://bugs.webkit.org/show_bug.cgi?id=188566
Attachment 347188: Patch
https://bugs.webkit.org/attachment.cgi?id=347188&action=review
--- Comment #5 from Megan Gardner <megan_gardner at apple.com> ---
Comment on attachment 347188
--> https://bugs.webkit.org/attachment.cgi?id=347188
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=347188&action=review
Assuming the win failure isn't an issue, and it's really fine to remove the
deleteSelectors definition. r=me
> Source/WebCore/css/CSSSelectorList.h:-73
> -
It's not clear to me why this is being removed.
> Source/WebCore/css/StyleRule.cpp:222
> }
Oh, these are being changed because they are now explicit?
More information about the webkit-reviews
mailing list