[webkit-reviews] review denied: [Bug 188704] [GTK][WPE] Make sure MediaDeviceEnabled and PeerConnectionEnabled are always synced with enable-media-stream : [Attachment 347376] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has denied Thibault Saunier
<tsaunier at gnome.org>'s request for review:
Bug 188704: [GTK][WPE] Make sure MediaDeviceEnabled and PeerConnectionEnabled
are always synced with enable-media-stream
https://bugs.webkit.org/show_bug.cgi?id=188704

Attachment 347376: Patch

https://bugs.webkit.org/attachment.cgi?id=347376&action=review




--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 347376
  --> https://bugs.webkit.org/attachment.cgi?id=347376
Patch

If the previous value was enabled, and the other settings were not already
enabled, there is a bug. If the previous value was disabled, and the other
settings were not already disabled, there is another bug.

Looks to me like the problem here was the initial states of these settings,
which should be addressed by changing the default values of the member
variables, right?

Might also be worth considering whether it makes sense to have three different
settings here.