[webkit-reviews] review granted: [Bug 188707] intersectionOfPastValuesAtHead must filter values after they've observed an invalidation point : [Attachment 347392] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 17 15:31:14 PDT 2018


Mark Lam <mark.lam at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 188707: intersectionOfPastValuesAtHead must filter values after they've
observed an invalidation point
https://bugs.webkit.org/show_bug.cgi?id=188707

Attachment 347392: patch

https://bugs.webkit.org/attachment.cgi?id=347392&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 347392
  --> https://bugs.webkit.org/attachment.cgi?id=347392
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347392&action=review

r=me

> Source/JavaScriptCore/ChangeLog:29
> +	   We fix this by filtering values in intersectionOfPastValuesAtHead as
> +	   with values as if an invalidation point has occured. This places the

The text "intersectionOfPastValuesAtHead as with values as if" is unclear. 
Looks like there's some partial edits here.  Please fix.


More information about the webkit-reviews mailing list