[webkit-reviews] review granted: [Bug 188695] [GLIB] Complete the JSCException API : [Attachment 347358] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 188695: [GLIB] Complete the JSCException API
https://bugs.webkit.org/show_bug.cgi?id=188695

Attachment 347358: Patch

https://bugs.webkit.org/attachment.cgi?id=347358&action=review




--- Comment #7 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 347358
  --> https://bugs.webkit.org/attachment.cgi?id=347358
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347358&action=review

> Source/JavaScriptCore/API/glib/JSCException.cpp:269
> +const char* jsc_exception_get_backtrace_string(JSCException* exception)

Hm, shouldn't it use const gchar*, for consistency with our other public APIs?
I know gchar/gint/etc. are dumb types, but consistency is good. Maybe you
should audit the entire JSC API for this. We definitely use the g types in the
WebKit2 API, for example.

> Source/JavaScriptCore/API/glib/JSCException.cpp:286
> + * Get the string representation of @exception error.
> + *
> + * Returns: (transfer full): the string representation of @exception error.

It reads better without the word "error" at the end.

"Get the string representation of @exception.

Returns: (transfer full): the string representation of @exception."