[webkit-reviews] review granted: [Bug 188583] [macOS] [WK2] Add infrastructure to test receiving file promises on drop : [Attachment 347129] Patch

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 188583: [macOS] [WK2] Add infrastructure to test receiving file promises on
drop
https://bugs.webkit.org/show_bug.cgi?id=188583

Attachment 347129: Patch

https://bugs.webkit.org/attachment.cgi?id=347129&action=review




--- Comment #4 from Andy Estes <aestes at apple.com> ---
Comment on attachment 347129
  --> https://bugs.webkit.org/attachment.cgi?id=347129
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347129&action=review

I'm not sure your unique filename finding logic in copyFile() is correct, but
otherwise looks great! r=me

> Tools/TestWebKitAPI/mac/TestFilePromiseReceiver.mm:48
> +    _promisedTypeIdentifiers = adoptNS(promisedTypeIdentifiers.copy);

I don't think dot syntax makes sense for -copy. It's an operation, not a
property.

> Tools/TestWebKitAPI/mac/TestFilePromiseReceiver.mm:101
> +	   NSString *adjustedFileName = suffix ?
fileNameWithNumericSuffix(fileName, suffix) : fileName;

Won't this try to copy to the same existing file path twice before appending a
numeric suffix?