[webkit-reviews] review denied: [Bug 188617] [Curl] Bug fix on deleting cookies when Max-Age is set to zero. : [Attachment 347206] PATCH
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 16 16:25:34 PDT 2018
Alex Christensen <achristensen at apple.com> has denied Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 188617: [Curl] Bug fix on deleting cookies when Max-Age is set to zero.
https://bugs.webkit.org/show_bug.cgi?id=188617
Attachment 347206: PATCH
https://bugs.webkit.org/attachment.cgi?id=347206&action=review
--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 347206
--> https://bugs.webkit.org/attachment.cgi?id=347206
PATCH
View in context: https://bugs.webkit.org/attachment.cgi?id=347206&action=review
> Source/WebCore/platform/network/curl/CookieJarDB.cpp:352
> + if (!cookie.session && expires <= ::time(0))
There are better ways of getting the current time in WebCore, like
MonotonicTime::now
More information about the webkit-reviews
mailing list