[webkit-reviews] review granted: [Bug 188676] Add temporary SPI WKContextHandlesSafeBrowsing : [Attachment 347299] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 16 15:07:47 PDT 2018


Joseph Pecoraro <joepeck at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 188676: Add temporary SPI WKContextHandlesSafeBrowsing
https://bugs.webkit.org/show_bug.cgi?id=188676

Attachment 347299: Patch

https://bugs.webkit.org/attachment.cgi?id=347299&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 347299
  --> https://bugs.webkit.org/attachment.cgi?id=347299
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347299&action=review

> Source/WebKit/UIProcess/API/C/mac/WKContextPrivateMac.h:77
> +WK_EXPORT bool WKContextHandlesSafeBrowsing();

Shouldn't this have some WK_API_AVAILABLE(...) macro? I thought we were doing
this for all our APIs and SPIs. I don't see it on any of our C APIs though =/


More information about the webkit-reviews mailing list