[webkit-reviews] review granted: [Bug 188664] [watchOS] Upstream Proximity Networking (nee Wi-Fi Assertions) : [Attachment 347304] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 188664: [watchOS] Upstream Proximity Networking (nee Wi-Fi Assertions)
https://bugs.webkit.org/show_bug.cgi?id=188664

Attachment 347304: Patch

https://bugs.webkit.org/attachment.cgi?id=347304&action=review




--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 347304
  --> https://bugs.webkit.org/attachment.cgi?id=347304
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347304&action=review

> Source/WebKit/Configurations/WebKit.xcconfig:104
> +WK_PROXIMITY_NETWORKING_LDFLAGS =
$(WK_PROXIMITY_NETWORKING_LDFLAGS_$(WK_PLATFORM_NAME));

Weird! This used to be about a framework, not a feature, but this is kind of
nice too I guess.

It will only last until someone needs one of these things for something else, I
guess.

> Source/WebKit/NetworkProcess/NetworkProcess.h:62
> +enum class WebsiteDataFetchOption;

I feel like this should sort between class and struct, but maybe not

> Source/WebKit/NetworkProcess/watchos/NetworkProximityManager.h:82
> +    enum class State {

Give it a size?