[webkit-reviews] review granted: [Bug 188601] Add script to generate WebContent service resource files : [Attachment 347285] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Ben Richards <benton_richards at apple.com>'s request
for review:
Bug 188601: Add script to generate WebContent service resource files
https://bugs.webkit.org/show_bug.cgi?id=188601

Attachment 347285: Patch

https://bugs.webkit.org/attachment.cgi?id=347285&action=review




--- Comment #15 from mitz at webkit.org ---
Comment on attachment 347285
  --> https://bugs.webkit.org/attachment.cgi?id=347285
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347285&action=review

> Source/WebKit/WebKit.xcodeproj/project.pbxproj:10147
> +				413E67622125E6E800C0F09E /* Copy Resources to
Framework Private Headers */,

Feels like some qualifier should come before “resources”.

> Source/WebKit/WebKit.xcodeproj/project.pbxproj:10506
> +				"$(TEMP_FILE_DIR)/$(FULL_PRODUCT_NAME).xcent",

Can also list $(BUILT_PRODUCTS_DIR)/$(INFOPLIST_PATH) here.