[webkit-reviews] review granted: [Bug 188665] Transition more WKWebViewConfiguration ivars to API::PageConfiguration values : [Attachment 347279] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 16 11:49:09 PDT 2018


Joseph Pecoraro <joepeck at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 188665: Transition more WKWebViewConfiguration ivars to
API::PageConfiguration values
https://bugs.webkit.org/show_bug.cgi?id=188665

Attachment 347279: Patch

https://bugs.webkit.org/attachment.cgi?id=347279&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 347279
  --> https://bugs.webkit.org/attachment.cgi?id=347279
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347279&action=review

r=me

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:-376
> -    configuration->_cpuLimit = self->_cpuLimit;

These copies are removed since PageConfiguration::copy already handles it?
Nice!


More information about the webkit-reviews mailing list