[webkit-reviews] review granted: [Bug 188639] Stop using canAuthenticateAgainstProtectionSpace in modern WebKit : [Attachment 347271] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 188639: Stop using canAuthenticateAgainstProtectionSpace in modern WebKit
https://bugs.webkit.org/show_bug.cgi?id=188639

Attachment 347271: Patch

https://bugs.webkit.org/attachment.cgi?id=347271&action=review




--- Comment #8 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 347271
  --> https://bugs.webkit.org/attachment.cgi?id=347271
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347271&action=review

> Source/WebKit/NetworkProcess/PreconnectTask.h:-53
> -    void canAuthenticateAgainstProtectionSpaceAsync(const
WebCore::ProtectionSpace&) final;

Maybe PreconnectTask no longer needs either to be CanMakeWeakPtr either.