[webkit-reviews] review granted: [Bug 178981] [WHLSL] Ternary expressions are unimplemented : [Attachment 346960] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 178981: [WHLSL] Ternary expressions are unimplemented
https://bugs.webkit.org/show_bug.cgi?id=178981

Attachment 346960: Patch

https://bugs.webkit.org/attachment.cgi?id=346960&action=review




--- Comment #5 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 346960
  --> https://bugs.webkit.org/attachment.cgi?id=346960
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346960&action=review

> Tools/WebGPUShadingLanguageRI/Parse.js:542
> +	   consume(":");

Should we add a test for this `consume` too? I don't think you added one