[webkit-reviews] review granted: [Bug 188464] Support drag-and-drop for input[type=color] : [Attachment 347173] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 15 14:05:24 PDT 2018
Wenson Hsieh <wenson_hsieh at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 188464: Support drag-and-drop for input[type=color]
https://bugs.webkit.org/show_bug.cgi?id=188464
Attachment 347173: Patch
https://bugs.webkit.org/attachment.cgi?id=347173&action=review
--- Comment #37 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 347173
--> https://bugs.webkit.org/attachment.cgi?id=347173
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=347173&action=review
> Source/WebCore/page/DragController.cpp:917
> + bool isColorControl = (is<HTMLInputElement>(state.source.get()) &&
downcast<HTMLInputElement>(*state.source.get()).isColorControl());
Nit - I don't think the extra ()'s around the RHS are needed. (The second
.get() can also be removed).
> Source/WebCore/page/DragController.cpp:1177
> + auto& input = downcast<HTMLInputElement>(*state.source.get());
Nit - The .get() is unnecessary here.
> Source/WebCore/page/mac/DragControllerMac.mm:148
> + supportedTypes.append(String(UIColorPboardType));
Nit - The explicit call to String() shouldn't be needed here.
More information about the webkit-reviews
mailing list