[webkit-reviews] review granted: [Bug 188588] [Curl] Don't send Content-Type header for POST request when body is null. : [Attachment 347126] PATCH

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 188588: [Curl] Don't send Content-Type header for POST request when body is
null.
https://bugs.webkit.org/show_bug.cgi?id=188588

Attachment 347126: PATCH

https://bugs.webkit.org/attachment.cgi?id=347126&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 347126
  --> https://bugs.webkit.org/attachment.cgi?id=347126
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=347126&action=review

> Source/WebCore/ChangeLog:9
> +	   when body is null.

Is it done for CURL only for POST when setting CURLOPT_POST?
Is it also happening for other methods like PUT?

> Source/WebCore/platform/network/curl/CurlRequest.cpp:468
> +	   m_curlHandle->removeRequestHeader("Content-Type"_s);

What happens if there are elementSize but no provided
HTTPHeaderName::ContentType?
If it is the default CURL, does it align with other ports?