[webkit-reviews] review denied: [Bug 188592] NetworkCORSPreflightChecker should proceed in case of ProtectionSpaceAuthenticationSchemeServerTrustEvaluationRequested even though the WebKit app is not implementing the didReceiveAuthenticationChallenge/didReceiveAuthenticationChallengeInFrame callback : [Attachment 347132] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied  review:
Bug 188592: NetworkCORSPreflightChecker should proceed in case of
ProtectionSpaceAuthenticationSchemeServerTrustEvaluationRequested even though
the WebKit app is not implementing the
didReceiveAuthenticationChallenge/didReceiveAuthenticationChallengeInFrame
callback
https://bugs.webkit.org/show_bug.cgi?id=188592

Attachment 347132: Patch

https://bugs.webkit.org/attachment.cgi?id=347132&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 347132
  --> https://bugs.webkit.org/attachment.cgi?id=347132
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347132&action=review

> Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.cpp:109
> +	   if (disposition == AuthenticationChallengeDisposition::Cancel &&
weakThis)

This feels iffy to me.	What about RejectProtectionSpace?

> Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.cpp:111
> +	       weakThis->wasBlocked();
> +	   completionHandler(disposition, credential);

This flow is not very clear.  Why do we need to call a completionHandler and
m_completionCallback, which seem to do separate things?