[webkit-reviews] review granted: [Bug 188580] LayoutTest inspector/worker/debugger-pause.html sometimes times out : [Attachment 347115] [PATCH] Proposed Fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 14 16:01:26 PDT 2018
Matt Baker <mattbaker at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 188580: LayoutTest inspector/worker/debugger-pause.html sometimes times out
https://bugs.webkit.org/show_bug.cgi?id=188580
Attachment 347115: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=347115&action=review
--- Comment #2 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 347115
--> https://bugs.webkit.org/attachment.cgi?id=347115
[PATCH] Proposed Fix
View in context: https://bugs.webkit.org/attachment.cgi?id=347115&action=review
r=me
> Source/WebInspectorUI/UserInterface/Protocol/Target.js:79
> + this.dispatchEventToListeners(WI.Target.Event.MainResourceAdded,
{resource});
Nit: I wouldn't bother including data for the event. A listener can just query
Target.mainResource if needed.
More information about the webkit-reviews
mailing list