[webkit-reviews] review granted: [Bug 188555] [LFC][Floating] Add support for negative clearance. : [Attachment 347079] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 14 12:25:01 PDT 2018


Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 188555: [LFC][Floating] Add support for negative clearance.
https://bugs.webkit.org/show_bug.cgi?id=188555

Attachment 347079: Patch

https://bugs.webkit.org/attachment.cgi?id=347079&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 347079
  --> https://bugs.webkit.org/attachment.cgi?id=347079
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347079&action=review

> Source/WebCore/layout/FloatingContext.cpp:155
> +	   auto absoluteTop =
FormattingContext::mapTopLeftToAncestor(layoutContext, layoutBox,
downcast<Container>(m_floatingState.root())).y;

Maybe don't call this absolute.

> Source/WebCore/layout/FloatingContext.cpp:164
> +	       // Previous inlflow's bottom margin is collapsed.

inlflow's

Maybe explain the assertion better, like "Previous inflow sibling has been laid
out already, so it's bottom margin will have been collapsed".

> Source/WebCore/layout/FloatingContext.cpp:168
> +	       // Reset previous's bottom and current's top to non-collapsing.

Say previous box


More information about the webkit-reviews mailing list