[webkit-reviews] review granted: [Bug 188559] Use a Variant instead of a union in CSSSelector : [Attachment 347092] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 188559: Use a Variant instead of a union in CSSSelector
https://bugs.webkit.org/show_bug.cgi?id=188559

Attachment 347092: Patch

https://bugs.webkit.org/attachment.cgi?id=347092&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 347092
  --> https://bugs.webkit.org/attachment.cgi?id=347092
Patch

Nice, r=me

At some point we'll need to rewrite these classes completely. We need separate
types for Compound/Complex/SimpleSelector instead of the current mess where
everything is a CSSSelector.