[webkit-reviews] review denied: [Bug 188516] [ews-build] Separate queues for Builders and Testers - macOS Sierra : [Attachment 347013] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 14 09:15:41 PDT 2018
Lucas Forschler <lforschler at apple.com> has denied Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 188516: [ews-build] Separate queues for Builders and Testers - macOS Sierra
https://bugs.webkit.org/show_bug.cgi?id=188516
Attachment 347013: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=347013&action=review
--- Comment #3 from Lucas Forschler <lforschler at apple.com> ---
Comment on attachment 347013
--> https://bugs.webkit.org/attachment.cgi?id=347013
Proposed patch
Mac OS is now called macOS...I think we should probably use 'macOS' everywhere,
rather than 'Mac'. I could be convinced to use MacOS (capitol M) since it is
the first letter of the class name. But, I would not oppose using lowercase.
others may have a stronger opinion. Please ask around and see what others
think.
Also, let's either fix the style errors, or override them for buildbot
instances if they are false.
More information about the webkit-reviews
mailing list