[webkit-reviews] review granted: [Bug 188551] Unhandled Promise Rejection logging in workers should not emit ErrorEvent to host Worker object : [Attachment 347076] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Yusuke Suzuki
<yusukesuzuki at slowstart.org>'s request for review:
Bug 188551: Unhandled Promise Rejection logging in workers should not emit
ErrorEvent to host Worker object
https://bugs.webkit.org/show_bug.cgi?id=188551

Attachment 347076: Patch

https://bugs.webkit.org/attachment.cgi?id=347076&action=review




--- Comment #8 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 347076
  --> https://bugs.webkit.org/attachment.cgi?id=347076
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347076&action=review

> Source/WebCore/dom/ScriptExecutionContext.cpp:-411
> -    logExceptionToConsole(errorMessage, sourceURL, lineNumber, columnNumber,
WTFMove(callStack));

Given its name, it seems strange that logExceptionToConsole would actually
dispatch an Error event to the worker host.
Is there a way to make things clearer?