[webkit-reviews] review granted: [Bug 188541] [LFC][Floating] Do not confuse clear with clearance. : [Attachment 347060] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 188541: [LFC][Floating] Do not confuse clear with clearance.
https://bugs.webkit.org/show_bug.cgi?id=188541

Attachment 347060: Patch

https://bugs.webkit.org/attachment.cgi?id=347060&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 347060
  --> https://bugs.webkit.org/attachment.cgi?id=347060
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347060&action=review

> Source/WebCore/layout/blockformatting/BlockFormattingContext.h:60
> +    void computeVerticalPositionForClear(const FloatingContext&, const Box&,
Display::Box&) const;

I would like to see the word "float" somewhere in the function name.

> Source/WebCore/layout/layouttree/LayoutBox.h:65
> +    bool hasClear() const;

This name sounds a bit too generic. Maybe hasFloatClear, or clearsFloats?