[webkit-reviews] review granted: [Bug 188530] [MotionMark] Update Leaves test : [Attachment 347037] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 13 15:50:44 PDT 2018
Said Abou-Hallawa <sabouhallawa at apple.com> has granted Jon Lee
<jonlee at apple.com>'s request for review:
Bug 188530: [MotionMark] Update Leaves test
https://bugs.webkit.org/show_bug.cgi?id=188530
Attachment 347037: Patch
https://bugs.webkit.org/attachment.cgi?id=347037&action=review
--- Comment #4 from Said Abou-Hallawa <sabouhallawa at apple.com> ---
Comment on attachment 347037
--> https://bugs.webkit.org/attachment.cgi?id=347037
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=347037&action=review
> PerformanceTests/MotionMark/tests/master/resources/leaves.js:85
> + this.element.style.opacity = this._opacity;
The use of this._opacity is be guarded by this.usesOpacity unless this._opacity
is always initialized with the default value. But I do not see that.
More information about the webkit-reviews
mailing list