[webkit-reviews] review granted: [Bug 181898] [WK2] [macOS] Implement a mechanism to test drag and drop : [Attachment 346957] Fix 32-bit macOS build

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 13 10:48:36 PDT 2018


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 181898: [WK2] [macOS] Implement a mechanism to test drag and drop
https://bugs.webkit.org/show_bug.cgi?id=181898

Attachment 346957: Fix 32-bit macOS build

https://bugs.webkit.org/attachment.cgi?id=346957&action=review




--- Comment #9 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 346957
  --> https://bugs.webkit.org/attachment.cgi?id=346957
Fix 32-bit macOS build

View in context: https://bugs.webkit.org/attachment.cgi?id=346957&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.h:26
> +#pragma once

Is this file needed at all?

> Tools/TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:47
> +    WeakObjCPtr<DragAndDropSimulator> _simulator;

I don't really like just "simulator": confused with iOS simulator. Maybe
_dragAndDropSimulator


More information about the webkit-reviews mailing list