[webkit-reviews] review requested: [Bug 188516] [ews-build] Separate queues for Builders and Testers - macOS Sierra : [Attachment 347013] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 13 07:11:25 PDT 2018


Aakash Jain <aakash_jain at apple.com> has asked  for review:
Bug 188516: [ews-build] Separate queues for Builders and Testers - macOS Sierra
https://bugs.webkit.org/show_bug.cgi?id=188516

Attachment 347013: Proposed patch

https://bugs.webkit.org/attachment.cgi?id=347013&action=review




--- Comment #1 from Aakash Jain <aakash_jain at apple.com> ---
Created attachment 347013

  --> https://bugs.webkit.org/attachment.cgi?id=347013&action=review

Proposed patch

This change results in a clear efficiency improvement. Instead of Building
(compiling WebKit) on multiple queues (WK1 and WK2), Build would be done only
on one queue (Builder) and it would be re-used on 3 queues (WK1, WK2,
API-tests).

For each patch, we are saving WebKit compilation time twice. This would results
in bots being more available and reduce the overall time engineers have to wait
to get the EWS results after a patch is uploaded.

Sample runs:

macOS-Sierra-Release-Build-EWS:
http://ews-build.webkit-uat.org/#/builders/25/builds/11
macOS-Sierra-Release-WK1-Tests-EWS:
http://ews-build.webkit-uat.org/#/builders/26/builds/13
macOS-Sierra-Release-WK2-Tests-EWS:
http://ews-build.webkit-uat.org/#/builders/27/builds/12


More information about the webkit-reviews mailing list