[webkit-reviews] review granted: [Bug 188491] ErrorEvent should not hold error strongly : [Attachment 346989] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 12 14:42:05 PDT 2018


Darin Adler <darin at apple.com> has granted Yusuke Suzuki
<yusukesuzuki at slowstart.org>'s request for review:
Bug 188491: ErrorEvent should not hold error strongly
https://bugs.webkit.org/show_bug.cgi?id=188491

Attachment 346989: Patch

https://bugs.webkit.org/attachment.cgi?id=346989&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 346989
  --> https://bugs.webkit.org/attachment.cgi?id=346989
Patch

I don’t fully understand the implications of aerialiing an object that could be
changed after its serialized. Or if we are doing the right thing when there are
multiple worlds involved. But that’s not specific to this patch, which is
applying a pattern we already follow elsewhere.


More information about the webkit-reviews mailing list