[webkit-reviews] review granted: [Bug 188477] [macOS] Color wells should appear pressed when presenting a color picker : [Attachment 346926] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 188477: [macOS] Color wells should appear pressed when presenting a color
picker
https://bugs.webkit.org/show_bug.cgi?id=188477

Attachment 346926: Patch

https://bugs.webkit.org/attachment.cgi?id=346926&action=review




--- Comment #6 from Tim Horton <thorton at apple.com> ---
Comment on attachment 346926
  --> https://bugs.webkit.org/attachment.cgi?id=346926
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346926&action=review

> Source/WebKit/UIProcess/mac/WebColorPickerMac.mm:55
> + at protocol WKPopoverColorWellDelegate<NSObject>

You should check, but I think we usually put a space before brackets for
protocol conformance

> Source/WebKit/UIProcess/mac/WebColorPickerMac.mm:277
> +	   [[NSColorPanel sharedColorPanel] setDelegate:nil];

Why do you use dot notation for delegate on one line and bracket notation on
the next? DOTS!