[webkit-reviews] review granted: [Bug 168091] [macOS debug] LayoutTest inspector/worker/resources-in-worker.html is a flaky timeout : [Attachment 346950] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Devin Rousso <webkit at devinrousso.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 168091: [macOS debug] LayoutTest inspector/worker/resources-in-worker.html
is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=168091

Attachment 346950: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=346950&action=review




--- Comment #10 from Devin Rousso <webkit at devinrousso.com> ---
Comment on attachment 346950
  --> https://bugs.webkit.org/attachment.cgi?id=346950
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=346950&action=review

r=me

> LayoutTests/ChangeLog:8
> +	   * inspector/worker/resources-in-worker-expected.txt:

Missing ChangeLog entries:
 * inspector/dom-debugger/resources/dataXHR.json: Added.
 * inspector/dom-debugger/xhr-breakpoints.html:

> LayoutTests/inspector/worker/resources-in-worker.html:61
> +		   if (workerIsReady && workerTargetIsSet)

Just as a thought, you could use two `WI.WrappedPromise` here and have the test
finish using `Promise.all([...]).then(resolve, reject);` or even make it async
and use await.