[webkit-reviews] review granted: [Bug 187542] Web Inspector: console.log fires getters for deep properties : [Attachment 346936] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 187542: Web Inspector: console.log fires getters for deep properties
https://bugs.webkit.org/show_bug.cgi?id=187542

Attachment 346936: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=346936&action=review




--- Comment #7 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 346936
  --> https://bugs.webkit.org/attachment.cgi?id=346936
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=346936&action=review

r=me

>>> Source/JavaScriptCore/inspector/InjectedScriptSource.js:1295
>>> +		 let descriptor = Object.getOwnPropertyDescriptor(object,
propertyName);
>> 
>> Might be worth verifying that we're ok w/ this doing effects? Like I believe
this calls a trap in a proxy.
> 
> Is there a way to tell if its a getter without an observable effect (without
being a built-in)?

Nope, not in a general way.