[webkit-reviews] review granted: [Bug 164833] LayoutTest inspector/worker/debugger-pause.html is a flaky failure : [Attachment 346941] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Joseph Pecoraro <joepeck at webkit.org>'s
request for review:
Bug 164833: LayoutTest inspector/worker/debugger-pause.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=164833

Attachment 346941: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=346941&action=review




--- Comment #6 from Brian Burg <bburg at apple.com> ---
Comment on attachment 346941
  --> https://bugs.webkit.org/attachment.cgi?id=346941
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=346941&action=review

r=me

> LayoutTests/inspector/worker/debugger-pause.html:115
> +    Promise.resolve().then(() => {

It would be interesting to abstract away the Promise mechanism to turn the
event loop. Say, turnEventLoop().then(... would make the comment disappear.

Is this something we should be doing in more worker tests? Would it be less
fragile for the worker to post back a "I'm initialized!" message then continue
the test? I think we use this pattern in Inspector layout test runner between
the inspector and inspected page.