[webkit-reviews] review granted: [Bug 188474] CrashTracer: com.apple.WebKit.Storage at WebCore::IDBServer::UniqueIDBDatabase::connectionClosedFromClient(WebCore::IDBServer::UniqueIDBDatabaseConnection&) : [Attachment 346923] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 188474: CrashTracer: com.apple.WebKit.Storage at
WebCore::IDBServer::UniqueIDBDatabase::connectionClosedFromClient(WebCore::IDBS
erver::UniqueIDBDatabaseConnection&)
https://bugs.webkit.org/show_bug.cgi?id=188474

Attachment 346923: Patch

https://bugs.webkit.org/attachment.cgi?id=346923&action=review




--- Comment #7 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 346923
  --> https://bugs.webkit.org/attachment.cgi?id=346923
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346923&action=review

r=me with comments.

> Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp:75
> +    if (m_database) {

This would look better as an early return.

> Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp:62
> +    ASSERT(database);

We probably want to null check it since we believe the transaction / connection
can outlive their database.