[webkit-reviews] review granted: [Bug 188477] [macOS] Color wells should appear pressed when presenting a color picker : [Attachment 346921] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 188477: [macOS] Color wells should appear pressed when presenting a color
picker
https://bugs.webkit.org/show_bug.cgi?id=188477

Attachment 346921: Patch

https://bugs.webkit.org/attachment.cgi?id=346921&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 346921
  --> https://bugs.webkit.org/attachment.cgi?id=346921
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346921&action=review

> Source/WebCore/platform/mac/ThemeMac.mm:714
> +    NSButtonCell *buttonCell = button(ColorWellPart, controlStates,
IntSize(zoomedRect.size()), zoomFactor);

This button is kept statically, right? Who unsets highlighted?

> Source/WebKit/UIProcess/WebColorPicker.cpp:48
> +    m_client = 0;

nullptr?

> Source/WebKit/UIProcess/mac/WebColorPickerMac.mm:98
> +    if (m_colorPickerUI) {

Why doesn't this just call endPicker?