[webkit-reviews] review granted: [Bug 188396] [ews-build] Separate queues for Builders and Testers - iOS : [Attachment 346745] Proposed patch

[bugzilla-daemon at webkit.org]

Lucas Forschler <lforschler at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 188396: [ews-build] Separate queues for Builders and Testers - iOS
https://bugs.webkit.org/show_bug.cgi?id=188396

Attachment 346745: Proposed patch

https://bugs.webkit.org/attachment.cgi?id=346745&action=review




--- Comment #3 from Lucas Forschler <lforschler at apple.com> ---
Comment on attachment 346745
  --> https://bugs.webkit.org/attachment.cgi?id=346745
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346745&action=review

> Tools/BuildSlaveSupport/ews-build/factories.py:88
> +class TestsFactory(Factory):

We use BuildFactory (singular)... maybe we should use TestFactory (singular)
here as well?
TestsFactory has a weird pronunciation.