[webkit-reviews] review granted: [Bug 188389] Avoid timeout resulted from calling waitUntilDone when test is not running : [Attachment 346854] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 9 12:02:28 PDT 2018
Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 188389: Avoid timeout resulted from calling waitUntilDone when test is not
running
https://bugs.webkit.org/show_bug.cgi?id=188389
Attachment 346854: Patch
https://bugs.webkit.org/attachment.cgi?id=346854&action=review
--- Comment #13 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 346854
--> https://bugs.webkit.org/attachment.cgi?id=346854
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=346854&action=review
r=me if Mac-wk2 EWS is green.
> Tools/ChangeLog:6
> + If test is not running, we should not set the waitUntilDone flag, or
it may cause subsequent tests timeout.
This should come *after* the Reviewed by line.
More information about the webkit-reviews
mailing list