[webkit-reviews] review denied: [Bug 188389] Avoid timeout resulted from calling waitUntilDone when test is not running : [Attachment 346850] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 9 11:32:35 PDT 2018
Chris Dumez <cdumez at apple.com> has denied Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 188389: Avoid timeout resulted from calling waitUntilDone when test is not
running
https://bugs.webkit.org/show_bug.cgi?id=188389
Attachment 346850: Patch
https://bugs.webkit.org/attachment.cgi?id=346850&action=review
--- Comment #10 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 346850
--> https://bugs.webkit.org/attachment.cgi?id=346850
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=346850&action=review
> Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:189
> + ASSERT(injectedBundle.isTestRunning());
Alexey asked for a release assertion.
More information about the webkit-reviews
mailing list