[webkit-reviews] review granted: [Bug 188445] Update IDL for IntersectionObserverEntry and IntersectionObserverEntryInit : [Attachment 346847] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Ali Juma
<ajuma at chromium.org>'s request for review:
Bug 188445: Update IDL for IntersectionObserverEntry and
IntersectionObserverEntryInit
https://bugs.webkit.org/show_bug.cgi?id=188445

Attachment 346847: Patch

https://bugs.webkit.org/attachment.cgi?id=346847&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 346847
  --> https://bugs.webkit.org/attachment.cgi?id=346847
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346847&action=review

> Source/WebCore/page/IntersectionObserverEntry.h:51
> +	   std::optional<DOMRectInit> rootBounds;
>	   DOMRectInit boundingClientRect;
>	   DOMRectInit intersectionRect;
> +	   bool isIntersecting;
> +	   double intersectionRatio;
>	   RefPtr<Element> target;

This would pack better if you put the bool at the end

> Source/WebCore/page/IntersectionObserverEntry.h:77
> +    bool m_isIntersecting { false };
>      double m_intersectionRatio { 0 };
>      RefPtr<Element> m_target;

Ditto