[webkit-reviews] review granted: [Bug 188412] [GTK] Mark some Web workers tests as flaky : [Attachment 346835] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted darshan
<dkadu at igalia.com>'s request for review:
Bug 188412: [GTK] Mark some Web workers tests as flaky
https://bugs.webkit.org/show_bug.cgi?id=188412

Attachment 346835: Patch

https://bugs.webkit.org/attachment.cgi?id=346835&action=review




--- Comment #6 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 346835
  --> https://bugs.webkit.org/attachment.cgi?id=346835
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346835&action=review

> LayoutTests/ChangeLog:3
> +	   Wokers related flaky tests

This line should be the title of the bug: "[GTK] Mark some Web workers tests as
flaky"

Also note wokers is misspelled

> LayoutTests/platform/gtk/TestExpectations:1936
> +webkit.org/b/188412
imported/w3c/web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/ex
ception-in-onerror.html [ Failure Pass ]

This should point to a different bug (which you can report now) to fix the
issue, since we want TestExpectations to point to open unresolved bugs. This
bug #188412 is going to be closed by commit-queue as soon as your patch is
committed.

> LayoutTests/platform/gtk/TestExpectations:1942
> +
> +

No need for two blank lines here. One will do.