[webkit-reviews] review denied: [Bug 188424] run-bindings-tests is not Win32-compatible : [Attachment 346815] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 8 21:25:26 PDT 2018


Fujii Hironori <Hironori.Fujii at sony.com> has denied Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 188424: run-bindings-tests is not Win32-compatible
https://bugs.webkit.org/show_bug.cgi?id=188424

Attachment 346815: Patch

https://bugs.webkit.org/attachment.cgi?id=346815&action=review




--- Comment #6 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 346815
  --> https://bugs.webkit.org/attachment.cgi?id=346815
Patch

So weird. I can't understand why this code works.
NamedTemporaryFile() returns file object.
You pass the file objects to generate_supplemental_dependency, not filenames.
Why does this code work?


More information about the webkit-reviews mailing list