[webkit-reviews] review granted: [Bug 188429] Prevent collectScreenProperties from crashing Base System : [Attachment 346812] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Justin Fan
<justin_fan at apple.com>'s request for review:
Bug 188429: Prevent collectScreenProperties from crashing Base System
https://bugs.webkit.org/show_bug.cgi?id=188429

Attachment 346812: Patch

https://bugs.webkit.org/attachment.cgi?id=346812&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 346812
  --> https://bugs.webkit.org/attachment.cgi?id=346812
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346812&action=review

> Source/WebCore/ChangeLog:9
> +	   Reviewed by NOBODY (OOPS!).

This should go above the description (use "webkit-patch upload" to prepare your
patches).

> Source/WebCore/platform/mac/PlatformScreenMac.mm:203
> +    CGLRendererInfoObj rendererInfo = 0;

nullptr, not 0

> Source/WebCore/platform/mac/PlatformScreenMac.mm:205
>      ASSERT(error == kCGLNoError);

We know this assert will fire on some systems, so remove it.