[webkit-reviews] review denied: [Bug 188410] InputType does not need to be RefCounted and probably shouldn't be : [Attachment 346785] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 188410: InputType does not need to be RefCounted and probably shouldn't be
https://bugs.webkit.org/show_bug.cgi?id=188410

Attachment 346785: Patch

https://bugs.webkit.org/attachment.cgi?id=346785&action=review




--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 346785
  --> https://bugs.webkit.org/attachment.cgi?id=346785
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346785&action=review

r- because of this will re-introduce the bug making InputType RefCounted fixed.

> Source/WebCore/ChangeLog:29
> +	   1. Use a EventQueueScope to dealy the firing of events, which we
already do in a few places

We can't do this for the particular use-after-free at hand.
We discussed this possibility in length and concluded that it's not viable.