[webkit-reviews] review denied: [Bug 188412] Wokers related flaky tests : [Attachment 346778] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 8 15:35:14 PDT 2018


Michael Catanzaro <mcatanzaro at igalia.com> has denied darshan
<dkadu at igalia.com>'s request for review:
Bug 188412: Wokers related flaky tests
https://bugs.webkit.org/show_bug.cgi?id=188412

Attachment 346778: Patch

https://bugs.webkit.org/attachment.cgi?id=346778&action=review




--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 346778
  --> https://bugs.webkit.org/attachment.cgi?id=346778
Patch

Yeah the errors need fixed:

> ERROR: LayoutTests/platform/gtk/TestExpectations:1936:  Path does not exist.
> [test/expectations] [5]
> ERROR:
> /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:
> 1936:  Path does not exist.  [test/expectations] [5]
> ERROR:
> /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:
> 1941:  Duplicate or ambiguous entry lines
> LayoutTests/platform/gtk/TestExpectations:1940 and
> LayoutTests/platform/gtk/TestExpectations:1941.  [test/expectations] [5]
> Total errors found: 3 in 2 files


More information about the webkit-reviews mailing list