[webkit-reviews] review granted: [Bug 188415] Yarr JIT should include annotations with dumpDisassembly=true : [Attachment 346794] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <yusukesuzuki at slowstart.org> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 188415: Yarr JIT should include annotations with dumpDisassembly=true
https://bugs.webkit.org/show_bug.cgi?id=188415

Attachment 346794: Patch

https://bugs.webkit.org/attachment.cgi?id=346794&action=review




--- Comment #4 from Yusuke Suzuki <yusukesuzuki at slowstart.org> ---
Comment on attachment 346794
  --> https://bugs.webkit.org/attachment.cgi?id=346794
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346794&action=review

r=me

> Source/JavaScriptCore/yarr/YarrDisassembler.h:77
> +    enum VectorOrder {

enum class?

> Source/JavaScriptCore/yarr/YarrDisassembler.h:109
> +    unsigned m_indentLevel;

Making `m_identLevel { 0 };` looks nice to me instead of initializing it in a
constructor.

> Source/JavaScriptCore/yarr/YarrJIT.cpp:45
> +//	 friend void jitCompile(VM*, YarrCodeBlock&, const String& pattern,
unsigned& numSubpatterns, const char*& error, bool ignoreCase, bool multiline);

Let's remove this.