[webkit-reviews] review granted: [Bug 188416] Import WPTs for IntersectionObserver : [Attachment 346790] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Ali Juma
<ajuma at chromium.org>'s request for review:
Bug 188416: Import WPTs for IntersectionObserver
https://bugs.webkit.org/show_bug.cgi?id=188416

Attachment 346790: Patch

https://bugs.webkit.org/attachment.cgi?id=346790&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 346790
  --> https://bugs.webkit.org/attachment.cgi?id=346790
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346790&action=review

> Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h:580
> +- (void)setIntersectionObserverEnabled:(BOOL)flag;
> +- (BOOL)intersectionObserverEnabled;

I don't think you need this. You can to through the (admittedly bad)
experimental features API.

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:870
> +    [preferences setIntersectionObserverEnabled:YES];

We really need to make this automatic. Sad that you have to do this.